Fixed: fixed double-click issue by adding loading states for accepting, recounting, and updating item statuses and disabled buttons untill action complete in Pending Review Tab (#639) #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, recounting, and updating item statuses and disabled buttons untill action complete in Pending Review Tab (hotwax#639)
… for item actions in Pending Review Tab and removed stale changes. (hotwax#639)
…or item actions in Pending Review Tab and updated footer loading state. (hotwax#639)
ymaheshwari1
requested changes
Mar 5, 2025
…oration in PendingReviewDetail.vue (hotwax#639)
|
current checks-
|
ymaheshwari1
requested changes
Apr 30, 2025
Comment on lines
+240
to
+242
| const isAnyItemUpdating = computed(() => { | ||
| return Object.values(isUpdatingItem.value).some((isUpdating) => isUpdating); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const isAnyItemUpdating = computed(() => { | |
| return Object.values(isUpdatingItem.value).some((isUpdating) => isUpdating); | |
| }); | |
| const isAnyItemUpdating = computed(() => Object.values(isUpdatingItem.value).some((isUpdating) => isUpdating)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#639
Short Description and Why It's Useful
Fixed the double-click issue by adding loading states for accepting, recounting, and updating item statuses and disabled buttons until action completes.
Screenshots of Visual Changes before/after (If There Are Any)
Screencast.from.04-03-25.04.46.55.PM.IST.webm
Contribution and Currently Important Rules Acceptance